feat: add anchors and coloring consistency - #21
Merged
Conversation
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
There was a problem hiding this comment.
Pull request overview
Adds shareable section anchors, standardizes quota coloring at 85%/95% thresholds, and groups GlobalTenantResource objects by namespace.
Changes:
- Adds reusable anchored headings and section wrappers.
- Centralizes quota severity thresholds and updates related UI/tests.
- Adds namespace grouping to resource flows and aligns sidebar icons.
Review findings:
- Moderate (2 votes):
ManagedResourceFlow.tsx:592counts the synthetic “Cluster scoped” group as a namespace. - Nit (2 votes):
AGENTS.md:487needs continuation indentation preserved.
Reviewed changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Reviewed change |
|---|---|
src/utils/utils.test.ts |
Tests usage severity bands. |
src/utils/quantity.ts |
Defines shared usage thresholds. |
src/index.tsx |
Aligns sidebar icon usage. |
src/components/tenants/TenantQuotaOverview.tsx |
Anchors quota overview headings. |
src/components/tenants/TenantList.tsx |
Anchors the tenant list heading. |
src/components/tenants/TenantDetail.tsx |
Anchors tenant detail sections. |
src/components/tenants/CreateTenantForm.tsx |
Anchors form sections. |
src/components/tenant-resources/TenantResourceList.tsx |
Anchors the resource list heading. |
src/components/tenant-resources/TenantResourceDetail.tsx |
Anchors resource detail sections. |
src/components/tenant-resources/GlobalTenantResourceList.tsx |
Anchors the global resource list heading. |
src/components/tenant-resources/GlobalTenantResourceDetail.tsx |
Anchors global resource detail sections. |
src/components/tenant-resources/CreateTenantResourceForm.tsx |
Anchors form sections. |
src/components/tenant-resources/CreateGlobalTenantResourceForm.tsx |
Anchors form sections. |
src/components/tenant-owners/TenantOwnerList.tsx |
Anchors the owner list heading. |
src/components/tenant-owners/TenantOwnerDetail.tsx |
Uses anchored detail sections. |
src/components/storage/TenantPersistentVolumes.tsx |
Anchors persistent-volume sections. |
src/components/storage/PersistentVolumeTenantIntegration.tsx |
Anchors integration sections. |
src/components/quotas/ResourcePoolList.tsx |
Anchors the resource pool list heading. |
src/components/quotas/resourcePoolHelpers.ts |
Applies shared severity bands. |
src/components/quotas/resourcePoolHelpers.test.ts |
Updates severity expectations. |
src/components/quotas/ResourcePoolDetail.tsx |
Anchors pool subsections. |
src/components/quotas/ResourcePoolClaimDetail.tsx |
Uses anchored claim sections. |
src/components/quotas/GlobalResourceQuotaList.tsx |
Anchors the quota list heading. |
src/components/quotas/globalResourceQuotaHelpers.ts |
Applies shared severity bands. |
src/components/quotas/GlobalResourceQuotaDetail.tsx |
Anchors quota configuration sections. |
src/components/quotas/GlobalCustomQuotaList.tsx |
Applies severity bands and anchors the list. |
src/components/quotas/GlobalCustomQuotaDetail.tsx |
Updates messaging and anchors sections. |
src/components/quotas/CustomQuotaList.tsx |
Applies severity bands and anchors the list. |
src/components/quotas/CustomQuotaDetail.tsx |
Updates messaging and anchors sections. |
src/components/quotas/CreateGlobalCustomQuotaForm.tsx |
Anchors form sections. |
src/components/quotas/CreateCustomQuotaForm.tsx |
Anchors form sections. |
src/components/proxy/GlobalProxySettingsList.tsx |
Anchors the list and error sections. |
src/components/proxy/GlobalProxySettingsDetail.tsx |
Uses anchored detail sections. |
src/components/overview/overviewStats.ts |
Applies shared severity bands. |
src/components/overview/overviewStats.test.ts |
Updates severity fixtures. |
src/components/overview/CapsuleEvents.tsx |
Anchors the events list. |
src/components/namespaces/NamespaceQuotaSystems.tsx |
Anchors effective-limit sections. |
src/components/namespaces/NamespaceCapsuleResources.tsx |
Anchors resource inventories. |
src/components/configuration/CapsuleConfigurationList.tsx |
Anchors list and error sections. |
src/components/configuration/CapsuleConfigurationDetail.tsx |
Uses anchored configuration sections. |
src/components/common/SummaryCardGrid.tsx |
Anchors summary headings. |
src/components/common/SectionAnchor.tsx |
Implements fragment anchors. |
src/components/common/SectionAnchor.test.ts |
Tests anchor helpers. |
src/components/common/ReplicationDependencies.tsx |
Uses anchored dependency sections. |
src/components/common/QuotaUsage.tsx |
Updates usage tooltip text. |
src/components/common/QuotaSources.tsx |
Uses anchored quota-source sections. |
src/components/common/QuotaClaims.tsx |
Updates usage bands and claim headings. |
src/components/common/QuotaAggregationView.tsx |
Uses anchored aggregation sections. |
src/components/common/ManagedResources.tsx |
Anchors inventory and diff headings. |
src/components/common/ManagedResourceFlow.tsx |
Groups global resources by namespace. |
src/components/common/ManagedResourceFlow.test.ts |
Tests namespace flow grouping. |
src/components/common/ConditionsAndEvents.tsx |
Uses anchored condition and event sections. |
src/components/common/CapsuleIcon.tsx |
Updates icon documentation. |
src/components/common/AnchoredSectionBox.tsx |
Adds an anchored SectionBox wrapper. |
AGENTS.md |
Documents anchor and icon conventions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| and tabs have a 62px minimum height; link buttons have a 48px minimum height. | ||
| Tenants without valid link targets do not render an empty link zone or `No | ||
| links configured` filler. An empty selection means **No Tenant Filter** and | ||
| links configured` filler. An empty selection means **No Tenant Filter** and |
Comment on lines
+592
to
+594
| {groupByNamespace && namespaceGroups.length > 0 && ( | ||
| <Chip size="small" color="primary" label={`${namespaceGroups.length} namespaces`} /> | ||
| )} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.