Kstatus compatibility - #7648
Conversation
(helm 4, Flux, Argo CD, kubectl wait) Signed-off-by: Giovanni Ferrara <giovanni.ferrara@ericsson.com>
Signed-off-by: Giovanni Ferrara <giovanni.ferrara@ericsson.com>
Signed-off-by: Giovanni Ferrara <giovanni.ferrara@ericsson.com>
Signed-off-by: Giovanni Ferrara <giovanni.ferrara@ericsson.com>
Signed-off-by: Giovanni Ferrara <giovanni.ferrara@ericsson.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7648 +/- ##
==========================================
- Coverage 82.32% 82.31% -0.02%
==========================================
Files 130 130
Lines 15624 15891 +267
==========================================
+ Hits 12863 13081 +218
- Misses 2478 2523 +45
- Partials 283 287 +4
🚀 New features to boost your workflow:
|
|
Thank You @fergian94 for contributing! I have now spent some time studying this topic, and as we discussed elsewhere, I can take over implementing it. I propose using a different approach than currently suggested: instead of adding a We also need to implement This is being addressed in #7664, so I think we can close this PR. |
|
Thank you Tero for taking over this PR.
I will follow it up with enthusiasm. I really appreciate your commitment!
Il Mar 11 Ago 2026, 20:32 Tero Saarni ***@***.***> ha scritto:
… Closed #7648 <#7648>.
—
Reply to this email directly, view it on GitHub
<#7648?email_source=notifications&email_token=AOTRE4MLRHS575BAO2FMFHT5JNRFNA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOJSHE3TSNJZGA2TLJTSMVQXG33OU5WWK3TUNFXW5JLFOZSW45FMMZXW65DFOJPWG3DJMNVQ#event-29297959055>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOTRE4LJSI2NY75ICNZ24IT5JNRFNAVCNFSNUABFKJSXA33TNF2G64TZHMYTAOBUGYZDQMRSHNEXG43VMU5TKMBRGA3TEOBUGQ32C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AOTRE4N2V6NLWE6PBNLP6G35JNRFNA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOJSHE3TSNJZGA2TLJTSMVQXG33OU5WWK3TUNFXW5JLFOZSW45FKMZXW65DFOJPWS33T>
and Android
<https://github.com/notifications/mobile/android/AOTRE4KWJEORE7X3LZQMIWT5JNRFNA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOJSHE3TSNJZGA2TLJTSMVQXG33OU5WWK3TUNFXW5JLFOZSW45FOMZXW65DFOJPWC3TEOJXWSZA>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Problem
Since the introduction of kstatus in Helm 4, custom resources can now be monitored during install. For HTTPProxy and ExtensionService CRs, the Valid condition type is not recognized by kstatus logic,
which specifically looks for a Ready condition. This causes Helm to assume resources are immediately ready, defeating the purpose of --wait.
Solution
Mirror the Valid condition into an additional Ready condition, which kstatus recognizes. The Valid condition is preserved for backward compatibility and Contour's existing tooling, while the Ready
condition enables proper integration with Helm 4, Flux, Argo CD, and kubectl wait.
Cleanup
Removed the workaround for #7391 in hack/generate-crd-yaml.sh as it is no longer needed with k8s.io/api v0.35.4.