Skip to content

fix patient records page overscroll bug - #1951

Merged
dczulada merged 3 commits into
masterfrom
fix/patient-records-overscroll
Jul 22, 2025
Merged

fix patient records page overscroll bug#1951
dczulada merged 3 commits into
masterfrom
fix/patient-records-overscroll

Conversation

@pwoleary

Copy link
Copy Markdown
Collaborator

Fixes bug of extra whitespace appearing under tables on patient records page caused by hidden text class for screen reader accessibility. Can confirm that screenreader accessibility still works, but bug is fixed.

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@dczulada

dczulada commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

@pwoleary
Looks like this is where the cucumber test is failing

page.assert_text m.description

Apparently, previously, the description appeared to be "visible" but now with a height of 0 it is no longer visible (even though I was never actually visible on the screen)

You can try this.

page.assert_text(:all, m.description)

@codecov

codecov Bot commented Jul 21, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (c3158a9) to head (b12daa0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
+ Coverage   94.18%   96.04%   +1.86%     
==========================================
  Files         157      157              
  Lines        7138     7138              
==========================================
+ Hits         6723     6856     +133     
+ Misses        415      282     -133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dczulada
dczulada merged commit 2778529 into master Jul 22, 2025
18 of 23 checks passed
@dczulada
dczulada deleted the fix/patient-records-overscroll branch August 5, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants