Improve scoop - #2065
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
+ Coverage 91.63% 91.66% +0.03%
==========================================
Files 159 159
Lines 7340 7369 +29
==========================================
+ Hits 6726 6755 +29
Misses 614 614 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dczulada
force-pushed
the
improve_scoop
branch
2 times, most recently
from
July 15, 2026 18:20
539cea9 to
3ca4310
Compare
break up scoop and filter from negation replacement
elsaperelli
requested changes
Jul 28, 2026
elsaperelli
left a comment
elsaperelli
left a comment
Collaborator
There was a problem hiding this comment.
One typo and one question!
| data_element.fields.keys.each do |field_name| | ||
| next if data_element[field_name].nil? | ||
|
|
||
| # Dianoses and Facility Locations are unique because they are arrays |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Dianoses and Facility Locations are unique because they are arrays | |
| # Diagnoses and Facility Locations are unique because they are arrays |
| doc.root.add_namespace_definition('sdtc', 'urn:hl7-org:sdtc') | ||
| # There should be 1 entry with encounter ids. The fixture measures do not have PhysicalExamPerformed criteria, so that entry will be filtered out | ||
| assert_equal 1, doc.xpath('//sdtc:templateId[@root="2.16.840.1.113883.10.20.24.3.150"]').size, 'There should be 1 entry with encounter ids' | ||
| assert_equal 2, doc.xpath('//sdtc:templateId[@root="2.16.840.1.113883.10.20.24.3.150"]').size, 'There should be 1 entry with encounter ids' |
Collaborator
There was a problem hiding this comment.
Should this still say "There should be 1 entry with encounter ids" even though we are doing assert_equal 2?
elsaperelli
requested changes
Jul 28, 2026
elsaperelli
left a comment
elsaperelli
left a comment
Collaborator
There was a problem hiding this comment.
One more small comment!
| doc.root.add_namespace_definition('sdtc', 'urn:hl7-org:sdtc') | ||
| # There should be 1 entry with encounter ids. The fixture measures do not have PhysicalExamPerformed criteria, so that entry will be filtered out | ||
| assert_equal 1, doc.xpath('//sdtc:templateId[@root="2.16.840.1.113883.10.20.24.3.150"]').size, 'There should be 1 entry with encounter ids' | ||
| assert_equal 2, doc.xpath('//sdtc:templateId[@root="2.16.840.1.113883.10.20.24.3.150"]').size, 'There should be 2 entry with encounter ids' |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert_equal 2, doc.xpath('//sdtc:templateId[@root="2.16.840.1.113883.10.20.24.3.150"]').size, 'There should be 2 entry with encounter ids' | |
| assert_equal 2, doc.xpath('//sdtc:templateId[@root="2.16.840.1.113883.10.20.24.3.150"]').size, 'There should be 2 entries with encounter ids' |
elsaperelli
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.
Submitter:
Reviewer 1:
Name:
Reviewer 2:
Name: