Skip to content

2027 cms iii - #2068

Merged
dczulada merged 6 commits into
masterfrom
2027_CMS_III
Jul 29, 2026
Merged

2027 cms iii#2068
dczulada merged 6 commits into
masterfrom
2027_CMS_III

Conversation

@dczulada

Copy link
Copy Markdown
Contributor

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.59%. Comparing base (92e068a) to head (c680026).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
app/models/cms_program_task.rb 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
- Coverage   91.71%   91.59%   -0.12%     
==========================================
  Files         159      159              
  Lines        7340     7378      +38     
==========================================
+ Hits         6732     6758      +26     
- Misses        608      620      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dczulada
dczulada marked this pull request as ready for review July 17, 2026 18:58
@dczulada
dczulada requested a review from elsaperelli July 20, 2026 20:07
@dczulada

Copy link
Copy Markdown
Contributor Author

Cat III IG

@dczulada

Copy link
Copy Markdown
Contributor Author

@elsaperelli elsaperelli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

'PCF APM Entity Identifier' => "//cda:participant/cda:associatedEntity/cda:id[@extension='#{entered_value}' and @root='2.16.840.1.113883.3.249.5.3']",
'MVP Code' => "//cda:participant[@typeCode='TRC']/cda:associatedEntity[@classCode='PROG']/cda:id[@extension='#{entered_value}' and @root='2.16.840.1.113883.3.249.5.6']",
'SSP PI Reporting' => "//cda:participant[@typeCode='IND']/cda:associatedEntity[@classCode='PROG']/cda:id[@extension='#{entered_value}' and @root='2.16.840.1.113883.3.249.5.7']",
'ASM Cohort' => "//cda:participant[@typeCode='TRC']/cda:associatedEntity[@classCode='PROG']/cda:id[@extension='#{entered_value}' and @root='2.16.840.1.113883.3.249.5.7']",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the root and typeCode here correct?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I based that off the example in the IG, not the shall statements. Looks like there is a disconnect. I think the shall statements should be what we use. I'll have to flag this for the QRDA team.

Screenshot 2026-07-28 at 1 09 20 PM

@dczulada
dczulada requested a review from elsaperelli July 28, 2026 17:45
Comment thread config/cms_ig.yml
description:
ep: 'Each ASM participant is assigned to a specific cohort.'
conf:
ep: '(CONF:CMS_160)'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 165?

@dczulada

Copy link
Copy Markdown
Contributor Author

I picked 160 since it was the parent conformance statement.

1 similar comment
@dczulada

Copy link
Copy Markdown
Contributor Author

I picked 160 since it was the parent conformance statement.

@elsaperelli elsaperelli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@dczulada
dczulada merged commit 1332304 into master Jul 29, 2026
11 checks passed
@dczulada
dczulada deleted the 2027_CMS_III branch August 5, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants