Skip to content

Feature branch - #1302

Closed
AkewakBiru wants to merge 3 commits into
projectdiscovery:mainfrom
AkewakBiru:feature-branch
Closed

Feature branch#1302
AkewakBiru wants to merge 3 commits into
projectdiscovery:mainfrom
AkewakBiru:feature-branch

Conversation

@AkewakBiru

@AkewakBiru AkewakBiru commented Dec 16, 2025

Copy link
Copy Markdown

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated module import paths throughout the codebase to align with new project namespace
  • Bug Fixes

    • Enhanced CORS middleware to dynamically resolve request origin from headers when configured, ensuring proper cross-origin request handling
    • Improved HTTP server responses to correctly propagate incoming request protocol version information

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 16, 2025

Copy link
Copy Markdown

Walkthrough

Module namespace migration from github.com/projectdiscovery/interactsh to github.com/AkewakBiru/interactsh across all imports and the go.mod file. Includes minor functional enhancements to HTTP server CORS and protocol handling.

Changes

Cohort / File(s) Summary
Module Configuration
go.mod
Updated module path declaration from github.com/projectdiscovery/interactsh to github.com/AkewakBiru/interactsh
Command-line Tools
cmd/interactsh-client/main.go, cmd/interactsh-server/main.go
Updated internal package imports to use new module namespace
Benchmark Tools
cmd/benchmark-server/duration-testing/bench.go, cmd/benchmark-server/load-testing/bench.go
Updated client and server package imports to reference new module namespace
Example Code
examples/client.go
Updated client and server package imports to use new module path
Internal Packages
internal/runner/healthcheck.go
Updated options package import to new module namespace
Client Package
pkg/client/client.go
Updated internal package imports (options, server, settings, storage) to new module namespace
Options Package
pkg/options/server_options.go
Updated server package import to new module namespace
Server Packages (Core)
pkg/server/server.go, pkg/server/server_test.go
Updated ACME, storage, and settings package imports to new module namespace
Server Packages (Infrastructure)
pkg/server/dns_server.go, pkg/server/metrics.go, pkg/server/responder_server.go, pkg/server/smb_server.go
Updated filewatcher and storage package imports to new module namespace
Server HTTP Handler
pkg/server/http_server.go
Updated ACME package import; added HTTP protocol version propagation to response recorder; enhanced CORS middleware to dynamically resolve origin from request when OriginURL is set to "ref_req_origin"

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Areas requiring extra attention:

  • pkg/server/http_server.go — Contains functional logic changes (HTTP protocol propagation and dynamic CORS origin resolution) beyond simple import updates; verify CORS behavior with various origin configurations and ensure protocol version handling matches expected HTTP semantics
  • Verify all import paths resolve correctly after module namespace change and that no circular dependencies or missing transitive dependencies are introduced

Poem

🐰 A hop through namespaces we go,
From projectdiscovery's old glow,
To AkewakBiru's brand new home,
Where imports dance and protocols roam,
CORS blooms dynamic, truth to show! 🌟

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Feature branch' is vague and does not convey meaningful information about the actual changes, which involve updating module paths from projectdiscovery to AkewakBiru namespace. Provide a more descriptive title that reflects the main change, such as 'Update module namespace from projectdiscovery to AkewakBiru' or 'Migrate import paths to AkewakBiru/interactsh module'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0eb8a06 and 13a7270.

📒 Files selected for processing (16)
  • cmd/benchmark-server/duration-testing/bench.go (1 hunks)
  • cmd/benchmark-server/load-testing/bench.go (1 hunks)
  • cmd/interactsh-client/main.go (1 hunks)
  • cmd/interactsh-server/main.go (1 hunks)
  • examples/client.go (1 hunks)
  • go.mod (1 hunks)
  • internal/runner/healthcheck.go (1 hunks)
  • pkg/client/client.go (1 hunks)
  • pkg/options/server_options.go (1 hunks)
  • pkg/server/dns_server.go (1 hunks)
  • pkg/server/http_server.go (2 hunks)
  • pkg/server/metrics.go (1 hunks)
  • pkg/server/responder_server.go (1 hunks)
  • pkg/server/server.go (1 hunks)
  • pkg/server/server_test.go (1 hunks)
  • pkg/server/smb_server.go (1 hunks)
🔇 Additional comments (16)
pkg/server/dns_server.go (1)

13-13: LGTM!

The internal import path update to the new module namespace is correct. External dependencies from projectdiscovery (gologger, utils) appropriately remain unchanged as they are third-party packages.

pkg/server/smb_server.go (1)

13-13: LGTM!

The internal import path for filewatcher package is correctly updated to the new module namespace.

pkg/server/server_test.go (1)

6-6: LGTM!

The internal import path for settings package is correctly updated to the new module namespace.

internal/runner/healthcheck.go (1)

9-9: LGTM!

The internal import path for options package is correctly updated to the new module namespace.

pkg/server/metrics.go (1)

6-6: LGTM!

The internal import path for storage package is correctly updated to the new module namespace.

go.mod (1)

1-1: Module namespace migration is complete.

All internal imports have been successfully updated to github.com/AkewakBiru/interactsh. No references to the old github.com/projectdiscovery/interactsh path remain in the codebase. External projectdiscovery dependencies are correctly maintained as external imports.

Run go mod tidy to ensure go.sum is updated if not already done.

cmd/benchmark-server/duration-testing/bench.go (1)

14-15: LGTM - Import paths updated for namespace migration.

The client and server package import paths have been correctly updated to the new module namespace with no functional changes.

cmd/benchmark-server/load-testing/bench.go (1)

8-8: LGTM - Import path updated for namespace migration.

The client package import path has been correctly updated to the new module namespace.

examples/client.go (1)

8-9: LGTM - Import paths updated for namespace migration.

The example code has been correctly updated with the new module namespace for client and server packages.

pkg/server/server.go (1)

8-9: LGTM - Import paths updated for namespace migration.

The server/acme and storage package import paths have been correctly updated to the new module namespace with no functional changes.

cmd/interactsh-client/main.go (1)

13-17: LGTM - Import paths updated for namespace migration.

All internal package imports (runner, client, options, server, settings) have been correctly updated to the new module namespace. The client functionality remains unchanged.

pkg/server/responder_server.go (1)

12-12: Import path migration is complete and consistent.

The filewatcher import has been correctly updated to the new namespace (github.com/AkewakBiru/interactsh) as part of a full codebase migration. All functional imports use the new namespace consistently.

pkg/client/client.go (1)

27-30: LGTM - Import paths updated for namespace migration.

The internal package imports (options, server, settings, storage) have been correctly updated to the AkewakBiru namespace throughout the codebase with no functional changes. However, one documentation reference remains in pkg/server/http_server.go that still links to the old projectdiscovery namespace in the HTML banner string (this is non-critical but could be updated for consistency if desired).

cmd/interactsh-server/main.go (1)

19-24: LGTM - Import paths updated for namespace migration.

All internal package imports have been correctly updated to the new module namespace (github.com/AkewakBiru/interactsh). The go.mod file is properly configured with the new module path, and no references to the old namespace remain. Server functionality is unchanged.

pkg/server/http_server.go (1)

116-117: LGTM! Protocol version propagation improves logging accuracy.

Setting the protocol version on the recorded response to match the incoming request ensures that httputil.DumpResponse produces accurate output for logging purposes.

pkg/options/server_options.go (1)

4-4: Import migration verified as complete.

The module namespace migration from github.com/projectdiscovery/interactsh to github.com/AkewakBiru/interactsh has been properly applied across the codebase. All import statements now use the new module path, and go.mod correctly declares the updated module. No further action required.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AkewakBiru AkewakBiru closed this Dec 16, 2025
@AkewakBiru
AkewakBiru deleted the feature-branch branch December 16, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant