Little help, Improve MultiLimiter safety and ergonomics#146
Conversation
Enforce non-empty keys for all limiters; require Duration > 0 (safer validation). Use ok from sync.Map.Load in get (more robust). Add helpers: Exists, Keys, Delete (Stop + remove), CanTakeErr, AddAndTakeErr. NewMultiLimiterEmpty(ctx) constructor.
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safer Options Validation
Robust Get Logic
okvalue fromsync.Map.Loadinstead of checkingval == nil.Useful APIs
Exists(key string) boolKeys() []stringDelete(keys ...string): Stop + remove to avoid resource retention.CanTakeErr(key string) (bool, error): does not swallow errors.AddAndTakeErr(opts *Options) error: explicit error return.Ergonomics
NewMultiLimiterEmpty(ctx)to create an instance without an initial limiter.