Skip to content

⚡ Optimize substring search in Google Visualization data table generation#231

Merged
projectedanx merged 1 commit into
masterfrom
optimize-substring-search-18087237518649471889
Jun 6, 2026
Merged

⚡ Optimize substring search in Google Visualization data table generation#231
projectedanx merged 1 commit into
masterfrom
optimize-substring-search-18087237518649471889

Conversation

@projectedanx

Copy link
Copy Markdown
Owner

💡 What:
Replaced strpos( $value, '[' ) !== 0 && strpos( $value, '{' ) !== 0 with ( !isset($value[0]) || ( $value[0] !== '[' && $value[0] !== '{' ) ) inside loops within includes/functions-infos.php.

🎯 Why:
The code iterates over many values and checks if they start with a bracket or brace to determine if they need quotes for JSON/JS array generation. Using strpos() in a loop adds unnecessary function call overhead. Directly checking the first character using array offset access ($value[0]) is significantly faster.

📊 Measured Improvement:
Created a benchmarking script simulating 10,000 values iterated over 1,000 times.

  • Baseline (strpos): ~6.38 seconds
  • Optimized (direct offset access): ~4.03 seconds
  • Improvement: ~36.8% reduction in execution time for this specific code block.

PR created automatically by Jules for task 18087237518649471889 started by @projectedanx

…tion

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@projectedanx projectedanx merged commit a4890fb into master Jun 6, 2026
21 of 22 checks passed
@projectedanx projectedanx deleted the optimize-substring-search-18087237518649471889 branch June 6, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant