Skip to content

allow flexible node versions - #210

Open
pwoleary wants to merge 1 commit into
cypress_v7from
fix/allow-flexible-node-version
Open

allow flexible node versions#210
pwoleary wants to merge 1 commit into
cypress_v7from
fix/allow-flexible-node-version

Conversation

@pwoleary

Copy link
Copy Markdown
Contributor

I updated the package.json file to allow for newer minor node versions, otherwise the dockerfile, using the latest 22.17 node base image, won't successfully build. I would have updated the yarn.lock file but it didnt change with the node version.

image

Pull requests into cqm-execution-service require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants