Evaluation verifier - #109
Merged
Merged
Conversation
lmd59
marked this pull request as ready for review
July 3, 2025 19:41
zacharyrobin
self-requested a review
July 7, 2025 20:32
zacharyrobin
reviewed
Jul 7, 2025
zacharyrobin
reviewed
Jul 7, 2025
zacharyrobin
approved these changes
Jul 8, 2025
Contributor
There was a problem hiding this comment.
Looks great! Tested with the https://github.com/cqframework/ecqm-content-r4-2021, ColorectalCancerScreeningsFHIR-bundle. We will want to update the test server with more bundles for demos. Also can consider in the future adding a disable to all of step 2 but thats outside the scope of this task. Great work :D
Merged
elsaperelli
requested changes
Jul 9, 2025
elsaperelli
left a comment
Contributor
There was a problem hiding this comment.
Just two small suggestions but looks great!!!
| } | ||
|
|
||
| /** | ||
| * Atom tracking and controlling the value of uploaded measure bundle |
Contributor
There was a problem hiding this comment.
This looks like it was maybe copied from measureBundle.ts, so I would update it so it includes info about the evaluation service url!
Contributor
Author
There was a problem hiding this comment.
Oops! Thanks for catching!
lmd59
commented
Jul 9, 2025
Co-authored-by: Elsa Perelli <eperelli@mitre.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an input for an evaluation service (server that implements deqm $evaluate) as well as a button to verify that the evaluation service has the measure with the same url/version as the chosen measure (either uploaded or from a measure repository).
Note: We do this as a verification of matching measures instead of using the evaluation service measure directly as fqm-testify's selected measure. This is because we cannot guarantee that the evaluation service supports $package, which is required to get all data needed for local required calculations. If the evaluation service does support $package, then the same url can be used as the measure repository in step 1. May provide a simpler way to combine these in the future.
New Behavior
Input text field for url and verify button, which confirms matching or gives an error notification.
Code Changes
evaluationatom to store information about the evaluation service needed for anticipated interactionsEvaluationServiceVerifiercomponent to support the url input, verification button, and verification information or errors.indexpageMeasureRepositoryUploadHeaderTesting Guidance
npm run checknpm run dev