Skip to content

Evaluation verifier - #109

Merged
lmd59 merged 3 commits into
mainfrom
evaluation-url
Jul 9, 2025
Merged

Evaluation verifier#109
lmd59 merged 3 commits into
mainfrom
evaluation-url

Conversation

@lmd59

@lmd59 lmd59 commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Summary

Adds an input for an evaluation service (server that implements deqm $evaluate) as well as a button to verify that the evaluation service has the measure with the same url/version as the chosen measure (either uploaded or from a measure repository).

Note: We do this as a verification of matching measures instead of using the evaluation service measure directly as fqm-testify's selected measure. This is because we cannot guarantee that the evaluation service supports $package, which is required to get all data needed for local required calculations. If the evaluation service does support $package, then the same url can be used as the measure repository in step 1. May provide a simpler way to combine these in the future.

New Behavior

Input text field for url and verify button, which confirms matching or gives an error notification.

Code Changes

  • Adds an evaluation atom to store information about the evaluation service needed for anticipated interactions
  • Adds an EvaluationServiceVerifier component to support the url input, verification button, and verification information or errors.
  • Adds use of the verifier component to the index page
  • Fixes a typo I noticed in MeasureRepositoryUploadHeader

Testing Guidance

  • npm run check
  • npm run dev
  • Upload a ecqm-content-r4-2021 measure bundle to fqm-testify (I think this is what we currently have loaded on abacus-dev). Uploaded measure needs to have the same url and version as a measure on the deqm-test-server.
  • Input the deqm-test-server internal base url to the url input
  • Press verify
  • Should respond by showing the deqm-test-server id for the corresponding measure
  • Also test by uploading a measure that is not on the deqm-test-server

@lmd59
lmd59 force-pushed the evaluation-url branch from b95ae0b to be9c622 Compare July 3, 2025 19:41
@lmd59
lmd59 marked this pull request as ready for review July 3, 2025 19:41
@zacharyrobin
zacharyrobin self-requested a review July 7, 2025 20:32
Comment thread components/measure-upload/EvaluationServiceVerifier.tsx
Comment thread components/measure-upload/EvaluationServiceVerifier.tsx
@elsaperelli
elsaperelli self-requested a review July 8, 2025 14:20
@elsaperelli elsaperelli self-assigned this Jul 8, 2025

@zacharyrobin zacharyrobin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested with the https://github.com/cqframework/ecqm-content-r4-2021, ColorectalCancerScreeningsFHIR-bundle. We will want to update the test server with more bundles for demos. Also can consider in the future adding a disable to all of step 2 but thats outside the scope of this task. Great work :D

@lmd59 lmd59 mentioned this pull request Jul 9, 2025

@elsaperelli elsaperelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small suggestions but looks great!!!

Comment thread state/atoms/evaluation.ts Outdated
}

/**
* Atom tracking and controlling the value of uploaded measure bundle

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it was maybe copied from measureBundle.ts, so I would update it so it includes info about the evaluation service url!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks for catching!

Comment thread pages/index.tsx
Comment thread components/measure-upload/EvaluationServiceVerifier.tsx Outdated
Comment thread state/atoms/evaluation.ts Outdated
Co-authored-by: Elsa Perelli <eperelli@mitre.org>

@elsaperelli elsaperelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo!

@lmd59
lmd59 merged commit bf8eed6 into main Jul 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants