[prometheus-fastly-exporter] Add podLabels support#6711
Open
dshackith wants to merge 5 commits intoprometheus-community:mainfrom
Open
[prometheus-fastly-exporter] Add podLabels support#6711dshackith wants to merge 5 commits intoprometheus-community:mainfrom
dshackith wants to merge 5 commits intoprometheus-community:mainfrom
Conversation
Signed-off-by: Daniel Shackelford <daniel.shackelford@ithaka.org>
Signed-off-by: Daniel Shackelford <daniel.shackelford@ithaka.org>
Signed-off-by: Daniel Shackelford <daniel.shackelford@ithaka.org>
Signed-off-by: Daniel Shackelford <daniel.shackelford@ithaka.org>
Signed-off-by: Daniel Shackelford <daniel.shackelford@ithaka.org>
sellers
reviewed
Mar 5, 2026
sellers
left a comment
sellers
left a comment
There was a problem hiding this comment.
I think this would be a good addition - pod labels are something I use a lot for doing reporting, permissions, and inventory.
| description: A Helm chart for the Prometheus Fastly Exporter | ||
| name: prometheus-fastly-exporter | ||
| version: 0.11.0 | ||
| version: 0.11.1 |
There was a problem hiding this comment.
I wonder if this should be 0.12.0 as it is more of a minor feature addition over a patch or fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This adds podLabels support to the chart. This is needed in environments where specific pod labels are required (e.g. cost attribution)
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])