[prometheus-blackbox-exporter] use kubernetes.io/metadata.name in networkPolicy#6713
Open
firasmosbehi wants to merge 1 commit intoprometheus-community:mainfrom
Conversation
…Policy Signed-off-by: Firas Mosbehi <firas.mosbehi@insat.ucar.tn>
monotek
requested changes
Mar 10, 2026
| - namespaceSelector: | ||
| matchLabels: | ||
| name: {{ .Values.networkPolicy.monitoringNamespaceName }} | ||
| kubernetes.io/metadata.name: {{ .Values.networkPolicy.monitoringNamespaceName }} |
Member
There was a problem hiding this comment.
As this is changing the current default behaviour i consider this a breaking change.
Therefore major version of the chart woul dneed an update.
Maybe make key and value configurable so the current default can be kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
prometheus-blackbox-exporternetwork policy namespace matching to use Kubernetes' well-known namespace label and addresses #6640.Problem
When
networkPolicy.allowMonitoringNamespaceis enabled, the chart currently matches onname=<namespace>. In many environments, deployers do not control namespace labels and cannot guarantee a customnamelabel exists.Root cause
templates/networkpolicy.yamlhardcodes the namespace selector key toname.Fix
nametokubernetes.io/metadata.name.11.8.0to11.8.1.Validation
helm lint charts/prometheus-blackbox-exporterhelm template test charts/prometheus-blackbox-exporter --set networkPolicy.enabled=true --set networkPolicy.allowMonitoringNamespace=true --set networkPolicy.monitoringNamespaceName=observabilitykubernetes.io/metadata.name: observability.Notes
This keeps the same user-facing value (
monitoringNamespaceName) while aligning selector behavior with a standard Kubernetes label.