[kube-state-metrics] fix: allow disabling cluster-wide CRD RBAC#6742
Open
Nirpesh551 wants to merge 1 commit intoprometheus-community:mainfrom
Open
[kube-state-metrics] fix: allow disabling cluster-wide CRD RBAC#6742Nirpesh551 wants to merge 1 commit intoprometheus-community:mainfrom
Nirpesh551 wants to merge 1 commit intoprometheus-community:mainfrom
Conversation
Signed-off-by: Nirpesh551 <nirpeshbhattarai551@gmail.com>
Nirpesh551
force-pushed
the
fix/ksm-crd-rbac
branch
from
5295aa9 to
8edfc94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes an issue where
kube-state-metricsforcefully requires cluster-widecustomresourcedefinitionslist/watch privileges whencustomResourceState.enabledis true. This prevents deployment for users who only have namespace-level privileges.This PR adds a new values flag
rbac.customResourceState.createClusterRoleRules(defaulting totruefor backwards compatibility) that allows users to opt out of the cluster-wide CRD RBAC rules while still using custom resource state metrics.Which issue this PR fixes
fixes #6708
Special notes for your reviewer
Hi! This is my first open-source contribution. Let me know if anything needs adjusting!
Checklist
[prometheus-couchdb-exporter])