expfmt: add NegotiateFormatsIncludingOpenMetrics#951
Open
dpacgdm wants to merge 1 commit into
Open
Conversation
dpacgdm
force-pushed
the
feat/negotiate-formats-including-openmetrics
branch
2 times, most recently
from
July 21, 2026 15:34
fe28cc9 to
34cf5a7
Compare
NegotiateIncludingOpenMetrics only returns the top Accept match, so servers that lack that format cannot fall back to the next recognised option without reimplementing negotiation. Return the full ordered list and keep the existing single-format helper as a thin wrapper. Signed-off-by: dpacgdm <dpac.gdm@gmail.com>
dpacgdm
force-pushed
the
feat/negotiate-formats-including-openmetrics
branch
from
July 21, 2026 15:36
34cf5a7 to
563548c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NegotiateFormatsIncludingOpenMetricsreturning all recognised Accept formats in preference orderNegotiateIncludingOpenMetricsas a wrapper that returns the first entryAddresses #928. This gives servers that support only a subset of formats a clean way to walk the client's preference list (example in the issue: protobuf preferred but unsupported → OpenMetrics → text).
Callers such as kube-state-metrics can use this for content negotiation; a local workaround is also possible without this API.
Test plan
go test ./expfmt/ -run Negotiate