ci: declare permissions on ci, generate-dashboards, grafana_dashboard#983
Merged
Merged
Conversation
- ci.yml + generate-dashboards.yaml: contents: read (yaml lint, dashboard generation diff check). - grafana_dashboard.yaml: contents: read + pull-requests: write. The workflow posts a success/failure comment via the GitHub Issues comments API using GITHUB_TOKEN. Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
61807e8 to
f8e8779
Compare
Contributor
Author
|
Hi @SuperQ, gentle ping on this. The PR has been open for 4 days without a review. I noticed you've been on the recent-merger side of recent merges in this repo, so I thought I'd reach out. When you have a moment, would you mind giving this a quick look? No urgency, just trying to keep it on the radar. Happy to address any feedback. |
Contributor
Author
|
Hey, Quick follow-up. Let me know if you'd prefer a different framing or smaller scope. Appreciated. |
ArthurSens
approved these changes
May 26, 2026
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
LGTM. I think a good idea would be to add zizmor as a github actions security linter :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENon the three workflows still inheriting org defaults:ci.yml—contents: readfor yamllint.generate-dashboards.yaml—contents: readfor the dashboard-generation diff check.grafana_dashboard.yaml—contents: read+pull-requests: write. The success/failure comment usescurl -X POST .../issues/$PR_NUMBER/commentswithGITHUB_TOKEN.