-
Notifications
You must be signed in to change notification settings - Fork 6
Module Federation: Build the Tailwind stylesheet once in core
#2105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 6 commits
4d4b2c4
9f20db1
004ce93
143b929
20c9120
ce418da
90d1a17
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import '../src/loadStyles' | ||
| import '../src/print.css' | ||
|
|
||
| import { | ||
| EDITOR_ROLES, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| import '../src/loadStyles' | ||
|
|
||
| import { | ||
| EDITOR_ROLES, | ||
| LECTURER_ROLES, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| import './loadStyles' | ||
|
|
||
| import('./bootstrap') | ||
|
|
||
| export { StudentDetail } from './provide/student_detail' |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| import '../loadStyles' | ||
|
|
||
| export { StudentDetail } from './student_detail' |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| import './styles.css' | ||
|
|
||
| import('./bootstrap') |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| import './styles.css' | ||
|
|
||
| import('./bootstrap') |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| import './styles.css' | ||
|
|
||
| import('./bootstrap') | ||
|
|
||
| export { StudentDetail } from './provide/student_detail' |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| import './styles.css' | ||
|
|
||
| import('./bootstrap') | ||
|
|
||
| export { StudentDetail } from './provide/student_detail' |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| import './styles.css' | ||
|
|
||
| import('./bootstrap') | ||
|
|
||
| export { StudentDetail } from './provide/student_detail' |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| import './styles.css' | ||
|
|
||
| import('./bootstrap') | ||
|
|
||
| export { StudentDetail } from './provide/student_detail' |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: prompt-edu/prompt
Length of output: 7973
🏁 Script executed:
Repository: prompt-edu/prompt
Length of output: 35871
🏁 Script executed:
Repository: prompt-edu/prompt
Length of output: 426
🌐 Web query:
Official actions/checkout documentation persist-credentials default💡 Result:
In the actions/checkout GitHub Action, the persist-credentials input defaults to true [1][2][3]. When set to true, the action configures the authentication token or SSH key with the local Git configuration, which allows subsequent scripts in the job to run authenticated Git commands [1][4]. The action automatically removes these credentials during post-job cleanup [1][5]. While there have been community discussions and pull requests proposing to change this default value to false to enhance security [6], as of August 23, 2026, the official documentation and the action's configuration files (action.yml) maintain a default value of true [1][2][3]. Users who wish to opt out of this behavior and prevent the credential from being persisted in the local Git configuration should explicitly set persist-credentials: false in their workflow configuration [1][4].
Citations:
Disable credential persistence for both checkouts.
The
devworkflow runs this reusable workflow forpull_requestevents. Setpersist-credentials: falseon bothactions/checkoutsteps. The workflow already limitsGITHUB_TOKENtocontents: read.🧰 Tools
🪛 zizmor (1.29.0)
[warning] 13-13: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
🤖 Prompt for AI Agents
Source: Linters/SAST tools