keep projections running as long events are loading

[unixslayer]

projections should keep running when:

• runs with keepRunning: true due it awaits for new events
• it did not reached end of the stream, e.g. in case of resetting

projection status should indicate actual status of projection therefore, idle should be set if projection wasn't supposed to keep running or end of stream was reached

[unixslayer]

@basz @prolic please, review.

[prolic]

Can you add tests (that fail without the change)?

…

On Wed, Apr 16, 2025, 18:44 Piotr Zając ***@***.***> wrote: @basz <https://github.com/basz> @prolic <https://github.com/prolic> please, review. — Reply to this email directly, view it on GitHub <#257 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADAJPHN2ZYDSUQBVCZEJ6D2Z3FNDAVCNFSM6AAAAAB3JK4HT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJQHA4DGOBVGA> . You are receiving this because you were mentioned.Message ID: ***@***.***> *unixslayer* left a comment (prooph/pdo-event-store#257) <#257 (comment)> @basz <https://github.com/basz> @prolic <https://github.com/prolic> please, review. — Reply to this email directly, view it on GitHub <#257 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADAJPHN2ZYDSUQBVCZEJ6D2Z3FNDAVCNFSM6AAAAAB3JK4HT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJQHA4DGOBVGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[unixslayer]

@prolic done

if merged, please also to release it.

[basz]

I can have a look later today. But am wondering if this should be considered a breaking change release.

Even though it's a small bug fix it changes a side effect that consuming applications might rely on.

Any advise on this?

[unixslayer]

I can have a look later today. But am wondering if this should be considered a breaking change release.

Even though it's a small bug fix it changes a side effect that consuming applications might rely on.

Any advise on this?

@basz this is somehow a follow-up to #246.

For projections running with keepRunning: true nothing changes. The problem comes with projections with keepRunning: false. Especially if you want to reset them. Before that bug was solved, projection status remains running with lock released if load_count is low so we know it has to be triggered once more so it will go to the end of the stream. But now, projection status is set to idle after handling loaded events therefore, before the end of the stream so we don't know if it actually finished.

I don't consider this as a BC but more like a critical issue fix in the context of projection management.

[unixslayer]

We are running all our projections with keepRunning: false so we don't have long running processes and trigger them only when they need to be triggered.

[basz]

Any tests included inside files named *TestCase aren't executed it seems.

(see with vendor/bin/phpunit --testdox)

Don't know if this slipped through or is an deliberate choice, but a lot of tests never ran... (including yours)

[basz]

see ./vendor/bin/phpunit --list-tests -c phpunit.postgres.xml

[unixslayer]

I didn't even notice that. Normally I run my own tests locally and let the test suite run in CI.

I think this is happening due to changes in PHPUnit itself. We've had that issue in the project some time ago when switching to a newer version.

I can check that later.

[unixslayer]

@basz this one is also ready for review and release ;)

[unixslayer]

I had to change a little bit logic in this test due now each projection will try to finish by itself

[unixslayer]

@basz sorry for pushing but is there any chance to have this reviewed by today?

[basz]

nice work. one thing i noticed without the changes to the PdoEventStoreReadModelProjector.php the tests never run to completion. I would expect a failing test in such a case. going to merge anyway, feel free to have a look at that.