Issue 3 - #5
Open
OyvindLGjesdal wants to merge 3 commits into
Open
Conversation
matthewhorridge
requested changes
Oct 30, 2017
matthewhorridge
left a comment
matthewhorridge
left a comment
Contributor
There was a problem hiding this comment.
These changes change the signature of public methods in a backwards incompatible way. This will break existing client code.
The method translate with the single axiom needs to be preserved (and possibly deprecated).
Author
|
I changed back Owlmpl.addAxiom(OwlAxiom axiom) to use method translate with the single axiom, and added back in translate with single axiom. I tried to refactor the common parts of the translate methods, but I'm not happy with the method names as I don't grasp everything that gets translated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I've had a look at #3, trying to solve protegeproject/sparql-query-plugin#5, and have had some luck with opening larger files in sparql-tab. It passes the current tests in the build, but I've not added any additional ones. My example ontology has 131 000 axioms and loads in 5-10 seconds.