Tidy and docs - #35
Conversation
Remove unused field in TokenValidator
…uthorizedCapabilities
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try(var tokenVerifierStatic = mockStatic(TokenVerifier.class)) { | ||
| tokenVerifierStatic.when(() -> TokenVerifier.create(jwt, AccessToken.class)) | ||
| .thenReturn(verifier); |
There was a problem hiding this comment.
The new JwtRolesExtractor tests rely on mockStatic(TokenVerifier.class), but the project only pulls in spring-boot-starter-test (mockito-core) and has no mockito-inline dependency or mockito-extensions/org.mockito.plugins.MockMaker configuration to enable static mocking. With the current dependencies, running the test suite will throw a MockitoException stating that the inline mock maker is not enabled and the tests will fail before any assertions execute.
Useful? React with 👍 / 👎.
2 participants
Cleans up keycloak, removes no-longer used functionality i.e. AuthorizationCommandsController. Removes previous verification functionality. Removes issuer uri property.
Note the "keycloak-admin" path element is renamed to the more standard name "keycloak" (PRs for other repos will be provided to take this into account).