Make the publish workflow push the image the build already produces - #38
Merged
Conversation
Publishing invoked dockerfile:push, a Maven plugin the project no longer declares, so every release since 2.0.0 has failed to publish an image. The regular package build already produces the image tagged with the pom version; the workflow now just builds and pushes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing a release ran
mvn -Prelease package dockerfile:push, but thedockerfile-maven-pluginis no longer declared in the pom — so the 2.0.1 release (and anything since 2.0.0 on this lineage) fails with No plugin found for prefix 'dockerfile' before pushing anything. The regularpackagebuild already produces the image tagged with the pom version; the workflow now builds it and pushes that tag.