Retire the WebSocket/STOMP stack now that events ride Server-Sent Events - #52
Merged
Conversation
The STOMP broker, its subscription interceptor, and the websocket push half of the event bridge are gone; the bridge now feeds the SSE stream registry alone and is named for what it does. Everything that lived in the websocket package but serves the SSE transport moved out of it: the application-wide ObjectMapper configuration to the gateway root, and the access manager, capabilities, wire DTOs, and the bridge itself to the sse package. The unused websocket-era packaged-event mirror is deleted outright, along with the /wsapps security rule and the allowed-origin setting only the broker consumed. The websocket starter is replaced by an explicit web starter. The web stack was in fact arriving transitively through webprotege-ipc, not the websocket starter as once assumed, but a web application should declare its web framework directly rather than lean on a library's transitive graph either way. Completes the gateway half of protegeproject/webprotege-gwt-ui#308 (epic protegeproject/webprotege-gwt-ui#303).
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway half of protegeproject/webprotege-gwt-ui#308, the epic's final cleanup. The STOMP broker, subscription interceptor,
/wsappsrule, and the websocket push half of the event bridge are removed; everything the SSE transport uses moved out of the websocket package (the app-wide ObjectMapper config to the gateway root; access manager, capabilities, wire DTOs, and the bridge — nowProjectEventsSseBridgeHandler— to the sse package). The dead websocket-era packaged-event mirror is deleted.Dependency note: the websocket starter is swapped for an explicit web starter. Verified by dependency-tree diff (web was actually arriving transitively via webprotege-ipc, so nothing was ever at risk — but a web app should declare its framework) and by the full suite including the Testcontainers context-load test: 63/63 green.
Grep gates:
stomp|sockjs|wsapps|websocketappear only in the two-line historical note in the bridge's javadoc.