Require email verification at registration (fixes #9) - #10
Merged
Conversation
With open self-registration and email-as-username, an unverified account can claim any email address as its identity. Turning on verifyEmail makes Keycloak send a verification link before the first login completes, so the email_verified claim actually proves inbox ownership - which pending sharing invitations (protegeproject/webprotege-backend-service#177) rely on to redeem automatically and safely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
webprotegerealm allows open self-registration with the email address as the username, butverifyEmailis off — so nothing ever proves that a person owns the address they registered with. An unverified account can claim any email as its identity.Change
One line in
webprotege.json:"verifyEmail": false→true.Effect
email_verified=truein tokens actually means inbox ownership.