fix: Parse character, octal, and hex string escapes - #2426
Open
jiang1997 wants to merge 1 commit into
Open
Conversation
Support additional protobuf character escapes, including escaped quotes, plus bounded octal and hexadecimal escapes. Add tests for parsed defaults and numeric escape boundaries. Unicode escapes and validation of malformed or unknown escapes remain unsupported.
Contributor
|
@jiang1997 Do you know what's the behavior of the |
Contributor
Author
|
@alexander-fenster Yes. I used the protobuf string literal grammar and protoc's tokenizer as references:
protoc consumes up to three octal digits and two hexadecimal digits. I also verified that the parsed defaults match protoc's output. |
Contributor
Author
|
Separately, Unicode escapes ( Would that make sense for a follow-up PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support additional protobuf character escapes, including escaped quotes, plus bounded octal and hexadecimal escapes. Add tests for parsed defaults and numeric escape boundaries.
Unicode escapes and validation of malformed or unknown escapes remain unsupported.