Fix test flakiness - #116
Open
radubahmata wants to merge 6 commits into
Open
Conversation
moodmosaic
reviewed
Sep 2, 2026
|
|
||
| assert_contains "hlog timestamp" \ | ||
| "$(date +%H:%M:%S)" "$PLAIN" | ||
| "12:34:56 harness[3] test message" "$PLAIN" |
Member
There was a problem hiding this comment.
Ah, was that adding to the flakiness?
Contributor
Author
There was a problem hiding this comment.
yep, if it gets to the next second between the two date invocations. previously it compared the real-time string to one extracted a few milliseconds before.
radubahmata
marked this pull request as ready for review
September 2, 2026 22:05
Contributor
Author
|
Note: usually tests are append-only, but the decision to change the ones covered by this PR is backed by failures encountered in other CI/local test runs. The most recent example: https://github.com/protocol-security/claude-swarm/actions/runs/33561114313/job/100033552849. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
.github/workflows/ci.yml: lint all scripts undertests/.tests/_test_env.sh: provide shared Git configuration isolation.tests/test_ci_workflows.sh: verify all test scripts load the shared environment and receive CI lint coverage.tests/test_harness.sh: use a fixedhlogtimestamp and explicit writable Git configuration for signing tests.tests/runtime_signal_trap.sh: wait for the expected commit before sending signals.tests/test_drivers.sh: bound reaper and watchdog tests without asserting wall-clock duration.tests/test_launch.shandtests/test_session_end_push.sh: replace local Git isolation with the shared environment.Self-review checklist
Test plan
./tests/test_drivers.sh../tests/test.sh --all.