Pure PHP: cleanly ignore bits in the 10-byte varints with bit above LSB set.#26871
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Pure PHP: cleanly ignore bits in the 10-byte varints with bit above LSB set.#26871copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_899065019
branch
4 times, most recently
from
fe7a613 to
5cdef4d
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_899065019
branch
from
5cdef4d to
a3affe3
Compare
…SB set. Still error out if the MSB in that is set (implying it would be an 11+ byte varint). This is not really functional change; today this flow is just silently 'weird' where readVarint64() can return a float64 since php silently promotes the type when it doesn't fit. PiperOrigin-RevId: 899065019
copybara-service
bot
force-pushed
the
test_899065019
branch
from
a3affe3 to
d8588c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure PHP: cleanly ignore bits in the 10-byte varints with bit above LSB set.
Still error out if the MSB in that is set (implying it would be an 11+ byte varint).
This is not really functional change; today this flow is just silently 'weird' where readVarint64() can return a float64 since php silently promotes the type when it doesn't fit.