fix(ui): exclude service filter from finding group resources endpoint#10652
Merged
Alan-TheGentleman merged 3 commits intomasterfrom Apr 10, 2026
Merged
Conversation
The service filter from the top-level finding groups page was being forwarded to the resources sub-endpoint, causing "No resources found" when a service filter was active.
Contributor
|
✅ All necessary |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Show a more descriptive message when no resources are found due to active filters.
Contributor
🔒 Container Security ScanImage: ✅ No Vulnerabilities DetectedThe container image passed all security checks. No known CVEs were found.📋 Resources:
|
Alan-TheGentleman
deleted the
fix/ui-finding-group-resources-service-filter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When a service filter (e.g. "account") was active on the finding groups page and a group row was expanded to show its resources, the
filter[service__in]parameter was being forwarded to the finding group resources sub-endpoint. This filter is not valid for the resources endpoint, causing it to return empty results ("No resources found").Description
Strip
filter[service__in]from the filters passed to the finding group resources endpoint innormalizeFindingGroupResourceFilters. Uses a declarativeFINDING_GROUP_ONLY_FILTERSconstant so additional finding-group-only filters can be added easily if needed.Steps to review
Checklist
UI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.