feat(api): add sort support for all finding group counter fields#10655
Open
AdriiiPRodri wants to merge 2 commits intomasterfrom
Open
feat(api): add sort support for all finding group counter fields#10655AdriiiPRodri wants to merge 2 commits intomasterfrom
AdriiiPRodri wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
✅ All necessary |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
4 package(s) affected
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10655 +/- ##
=======================================
Coverage 93.60% 93.61%
=======================================
Files 227 227
Lines 31906 31923 +17
=======================================
+ Hits 29867 29884 +17
Misses 2039 2039
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The finding groups endpoint exposes granular counter fields (per-status muted counts, new/changed breakdowns) but they were not sortable. This adds sort support for all counter fields so the UI can order finding groups by any metric.
Description
_FINDING_GROUP_SORT_MAP:pass_muted_count,fail_muted_count,manual_muted_count, and allnew_*/changed_*breakdown countersdeltasort for backwards compatibility (expands tonew_count, changed_count)listandlatestendpointsSteps to review
_FINDING_GROUP_SORT_MAPinapi/src/backend/api/v1/views.pytest_views.pycovers all 15 new sort fieldspoetry run pytest api/src/backend/api/tests/test_views.py -k "test_finding_groups_sort_by_counter_fields" -xChecklist
Community Checklist
API (if applicable)
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.