feat(github): add check to ensure previous approvals are dismissed when updates are introduced#10656
Open
raajheshkannaa wants to merge 1 commit intoprowler-cloud:masterfrom
Conversation
…en updates are introduced Add repository_default_branch_dismiss_stale_reviews_enabled check to verify that repositories have the "Dismiss stale pull request approvals when new commits are pushed" setting enabled on their default branch protection rules. This implements CIS Control 1.1.4, ensuring that once a code change proposal is updated, all previously granted approvals are invalidated and fresh reviews are required. Changes: - Added dismiss_stale_reviews field to the Branch model in repository_service.py - Created check implementation following existing GitHub check patterns - Created metadata with severity, categories, and remediation steps - Added 4 unit tests: no repos, disabled (FAIL), enabled (PASS), None (skipped) - All 78 existing GitHub repository tests pass (zero regressions) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
provider/github
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10656 +/- ##
===========================================
- Coverage 93.60% 78.04% -15.57%
===========================================
Files 227 33 -194
Lines 31906 1143 -30763
===========================================
- Hits 29867 892 -28975
+ Misses 2039 251 -1788
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new GitHub provider check
repository_default_branch_dismiss_stale_reviews_enabledto verify that repositories have the Dismiss stale pull request approvals when new commits are pushed setting enabled on their default branch protection rules.This implements CIS Control 1.1.4, ensuring that once a code change proposal is updated, all previously granted approvals are invalidated and fresh reviews are required.
Changes
dismiss_stale_reviewsfield to theBranchmodel inrepository_service.pyDocumentation
Fixes #8660