test(ui): drop organization unit tests restated by integration - #12382
Conversation
pfe-nazaries
added
the
no-changelog
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request removes GCP organization selector tests, updates organization setup submission coverage for discovery recovery, and removes ADVANCED organization scan-launch tests for partial, failed, and empty bulk schedule responses. ChangesOrganization test coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ No Conflicts No conflict markers, and the branch merges cleanly into its base. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
🔒 Container Security ScanImage: ✅ No Vulnerabilities DetectedThe container image passed all security checks. No known CVEs were found.📋 Resources:
|
🔎 Container Security Scan (Grype)Image: ✅ Nothing BlockingNo findings at critical or high severity. 📋 Resources:
|
alejandrobailo
left a comment
alejandrobailo
left a comment
There was a problem hiding this comment.
I found three coverage regressions in this test-only cleanup. The replacement integration tests do not fully restate the deleted behavior. Please restore equivalent assertions before removing these tests.
- Delete the GCP method selector suite, covered by the GCP integration gating and entry tests - Trim the launch-step schedule outcomes the AWS/GCP integration launch tests already assert - Trim the setup-chain happy path and discovery retry from the submission hook suite
- Restore the discovery-retry case: the MSW handler answers every trigger with one static discovery, so integration can only count POSTs - Restore the GCP OSS gating case: the cloud upgrade modal mounts outside the providers page, so the harness cannot see the upsell open
25ac2b2 to
c20b924
Compare
|
All three hold. Two are restored here (
Coverage map for the remaining deletions —
One note on framing: those integration tests are not new to #12383 — they are already on |
Alan-TheGentleman
left a comment
Alan-TheGentleman
left a comment
There was a problem hiding this comment.
The prior clean review remains valid after the focused test-only updates. Approved.
3 participants
Context
First batch of the UI testing policy the team has been converging on: minimum number of tests for maximum user-facing coverage. Every test deleted here is already restated, verbatim or near-verbatim, by a named integration test that drives the real providers page through the browser — so the unit test buys nothing but a second place to maintain the same assertion.
This is layer 1 of the Azure Management Group onboarding stack. It depends on nothing and touches no production code.
Description
Removed:
gcp-method-selector.test.tsx— the whole file. Both tests are restated by the GCP integration gating/entry tests.org-launch-scan.test.tsx— the ADVANCED-path cases whose schedule/launch outcomes the AWS and GCP integration launch tests already assert. Deliberately kept: the loading state, the transport-failure path, and theDAILY_LEGACY/MANUAL_ONLY/BLOCKEDdescribes, none of which have an integration twin.use-org-setup-submission.test.ts— the happy path and the retry case. Deliberately kept: the fake-timer timeout/resume path and the error-routing matrix, which are internal enough to warrant a unit test.aws-method-selector.test.tsxis explicitly not touched: AWS OSS gating has no integration counterpart.Five further candidates were identified and left for a later batch rather than widening this PR.
Steps to review
cd ui && pnpm exec vitest run --project unit— green.cd ui && pnpm exec vitest run --project integration— green, and unchanged by this PR.Checklist
<component>/changelog.d/, if applicable. — not applicable, test-only; PR labelledno-changelog.UI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Summary by CodeRabbit