[CHAIN] feat(ui): add Registry permission support - #12495
alejandrobailo merged 1 commit into
Conversation
- Propagate Registry access through Cloud role and session models - Preserve safe defaults and non-Cloud permission behavior - Add default-off environment typing and focused coverage
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| // Prowler Cloud deployment flag — runtime read (server env, client island). | ||
| UI_CLOUD_ENABLED?: "true" | "false"; | ||
| UI_REGISTRY_ENABLED?: "true" | "false"; |
There was a problem hiding this comment.
Should this env var be seteable also in runtime?
🔗 Part of Chained PRs
feat/prowler-2414-registry-uifeat/prowler-2414-registry-uiChain Overview
Scope
manage_registrypropagation through Cloud roles, auth/session models, UI permission metadata, false defaults, and localUI_REGISTRY_ENABLEDtyping.Autonomy
Context
The Registry UI must fail closed and remain hidden until later slices add fresh Cloud, runtime-flag, and permission checks. This first slice introduces only the permission and configuration representation that those guards will consume.
Keeping this foundation separate makes role/session behavior reviewable before any Registry route or API integration exists.
Description
manage_registryto the existing user, role, auth, and permission models with false defaults.true.UI_REGISTRY_ENABLEDenvironment typing without enabling or exposing Registry.No npm dependency, backend endpoint, migration, public runtime-config field, Registry route, or user-visible Registry workflow is introduced.
Steps to review
manage_registryand non-Cloud payloads omit it.UI_REGISTRY_ENABLEDis typed but is not consumed to expose Registry UI.cd ui && pnpm exec vitest run --project unit actions/auth/auth.test.ts auth.config.test.ts types/formSchemas.test.ts actions/roles/roles.test.ts components/roles/workflow/forms/add-role-form.test.tsx components/roles/workflow/forms/edit-role-form.test.tsx components/layout/app-sidebar/navigation-config.test.ts lib/helper.test.ts lib/permissions.test.ts lib/runtime-env.test.tsand verify 123 tests pass.cd ui && pnpm run typecheckandcd ui && pnpm run test:unit; the recorded results are PASS and 3,047 passing unit tests.Checklist
Community Checklist
SDK/CLI
UI
no-changelog, and the user-visible slice will add the feature fragment.API
MCP Server
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.