fix(api): update unique constraint for Provider model to exclude soft… - #9054
Merged
AdriiiPRodri merged 8 commits intoNov 7, 2025
Merged
AdriiiPRodri merged 8 commits into
AdriiiPRodri merged 8 commits into
Conversation
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
|
✅ All necessary |
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
4 package(s) affected
|
rakan-pro
force-pushed
the
PROWLER-290-allow-multiple-provider-uid-when-they-are-deleted
branch
from
November 4, 2025 08:00
af88f93 to
70105b2
Compare
…-deleted entries This change modifies the unique constraint on the Provider model to ensure that it only considers non-deleted entries. A new migration has been created to reflect this change in the database schema. Additionally, tests have been added to verify the behavior of soft deletion and the uniqueness of provider entries.
…-deleted entries This change modifies the unique constraint on the Provider model to ensure that it only considers non-deleted entries. A new migration has been created to reflect this change in the database schema. Additionally, tests have been added to verify the behavior of soft deletion and the uniqueness of provider entries.
rakan-pro
force-pushed
the
PROWLER-290-allow-multiple-provider-uid-when-they-are-deleted
branch
3 times, most recently
from
November 6, 2025 06:39
dd4808d to
ed811de
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9054 +/- ##
===========================================
+ Coverage 54.42% 94.26% +39.84%
===========================================
Files 87 149 +62
Lines 2850 18695 +15845
===========================================
+ Hits 1551 17623 +16072
+ Misses 1299 1072 -227
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
rakan-pro
force-pushed
the
PROWLER-290-allow-multiple-provider-uid-when-they-are-deleted
branch
from
November 6, 2025 08:24
925f861 to
9d78bf2
Compare
AdriiiPRodri
previously approved these changes
Nov 6, 2025
josema-xyz
previously approved these changes
Nov 6, 2025
…en-they-are-deleted
rakan-pro
dismissed stale reviews from josema-xyz and AdriiiPRodri
via
November 7, 2025 12:06
4c9a351
AdriiiPRodri
approved these changes
Nov 7, 2025
josema-xyz
approved these changes
Nov 7, 2025
AdriiiPRodri
deleted the
PROWLER-290-allow-multiple-provider-uid-when-they-are-deleted
branch
November 7, 2025 12:16
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Alan-TheGentleman
pushed a commit
that referenced
this pull request
Nov 10, 2025
Alan-TheGentleman
pushed a commit
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This change addresses an issue where attempting to soft-delete a provider that was already soft-deleted would result in a duplicate error.
Description
This change modifies the unique constraint on the
Providermodel to ensure that it only considers non-deleted entries.A new migration has been created to reflect this change in the database schema.
Additionally, tests have been added to verify the behavior of soft deletion and the uniqueness of provider entries.
Steps to review
tenant_id,provider,uid). This should succeed.UniqueConstraint)Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.