Fixes related to PNG - #94
Open
CounterPillow wants to merge 2 commits into
Open
CounterPillow wants to merge 2 commits into
CounterPillow wants to merge 2 commits into
Conversation
texure_from_png assumed that everything 32 bit must be RGBA, and everything less than that must be RGB. This is wrong. PNG allows for transparency even in palette or grayscale mode using the tRNS chunk. Let's convert to RGBA if we have transparency, and convert to RGB if we don't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a bug today when my package manager automatically losslessly optimised the PNG images that PrusaControl uses: it doesn't have proper logic for loading them. So I've fixed it, and also optimised the PNGs inside the repo.
texture_from_png made several wrong assumptions:
The fix is twofold: