Fix: Node auto deploy using key with insufficient permissions - #5665
Closed
danny6167 wants to merge 1 commit into
Closed
Fix: Node auto deploy using key with insufficient permissions#5665danny6167 wants to merge 1 commit into
danny6167 wants to merge 1 commit into
Conversation
Contributor
|
thanks for tracking this down i'm gonna close this and fix it in a separate commit. i don't think we want to solve this by giving the generated key full node write perms since that's broader than the configure flow needs. as it's definitely a regression from a previous security patch 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You now require write access to the node endpoint to pull the config.
This change updates the token fetching/generation to use a token with R&W permissions
Fixes #5664