Resolve UDP printer_address label via reverse DNS - #127
Open
cryptomilk wants to merge 1 commit into
Open
cryptomilk wants to merge 1 commit into
cryptomilk wants to merge 1 commit into
Conversation
The UDP syslog listener sets the printer_address label from the raw syslog source IP. This mismatches PrusaLink metrics which use the configured address (hostname or IP from prusa.yml), breaking Grafana dashboard filters that join both metric types by printer_address. At startup, resolve each printer's configured address to its IP(s) and register a canonical IP->address mapping in the UDP package. resolveAddr() checks this map first, so UDP metrics use the exact same address string as PrusaLink metrics Falls back to reverse DNS short hostname, then raw IP, for any printer not in the config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UDP syslog listener sets the printer_address label from the raw syslog source IP. This mismatches PrusaLink metrics which use the configured address (hostname or IP from prusa.yml), breaking Grafana dashboard filters that join both metric types by printer_address.
Add a cache with a reverse DNS lookup on the syslog source IP and strip the domain to produce a short hostname.
Falls back to the raw IP if DNS fails. Cache prevents per-packet DNS overhead.