-
Notifications
You must be signed in to change notification settings - Fork 882
feat: add disable hotkeys feature #1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
do4Mother
wants to merge
7
commits into
puckeditor:main
Choose a base branch
from
do4Mother:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5220866
feat: add disable hotkeys feature
07cadab
feat: integrate hotkey state into app state
a18c030
fix: remove debug log from monitorHotkeys function
d83ca0b
refactor: hotkey state to AppStore
e025ac8
fix: change hotkeys type to Partial<HotkeyState>
ef7b741
fix: simplify hotkeys prop handling
9320692
fix: prevent re-render generateAppStore from hotkeys object
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,10 @@ export type ItemWithId = { | |
|
|
||
| export type ArrayState = { items: ItemWithId[]; openId: string }; | ||
|
|
||
| export type HotkeyState = { | ||
| enabled: boolean; | ||
| } | ||
|
|
||
| export type UiState = { | ||
| leftSideBarVisible: boolean; | ||
| rightSideBarVisible: boolean; | ||
|
|
@@ -39,6 +43,7 @@ export type UiState = { | |
| }; | ||
|
|
||
| export type AppState<UserData extends Data = Data> = { | ||
| hotkeys: HotkeyState; | ||
|
||
| data: UserData; | ||
| ui: UiState; | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to use a
Partialhere and handle that optionality (applying defaults) before passing it down to theappStore.We might introduce more options in the future, and requiring
enabledcould become inconvenient, some users might only want to enable a single option.