Skip to content

feat: 設定情報をファイルから読むconfigパッケージを実装#1530

Merged
laminne merged 4 commits intomainfrom
feat/1339-config
Apr 13, 2026
Merged

feat: 設定情報をファイルから読むconfigパッケージを実装#1530
laminne merged 4 commits intomainfrom
feat/1339-config

Conversation

@laminne
Copy link
Copy Markdown
Member

@laminne laminne commented Apr 3, 2026

close #1339

What does this PR do?

  • インスタンスの設定情報を管理するための config パッケージを実装
    • 設定値が期待する形式を満たさない場合はエラー終了する

Additional information

  • 残りToDo:
    • ファイルを実際に読み込む部分の実装

@laminne laminne self-assigned this Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.77%. Comparing base (dcafa30) to head (d0b908c).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
pkg/config/adaptor/dummy.ts 83.33% 1 Missing ⚠️
pkg/config/adaptor/local.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
+ Coverage   42.33%   42.77%   +0.43%     
==========================================
  Files         143      148       +5     
  Lines        5461     5506      +45     
  Branches      941      945       +4     
==========================================
+ Hits         2312     2355      +43     
- Misses       3149     3151       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laminne laminne requested a review from MikuroXina April 12, 2026 15:17
@laminne laminne marked this pull request as ready for review April 12, 2026 15:17
@laminne laminne enabled auto-merge April 12, 2026 15:18
@laminne laminne requested a review from MikuroXina April 13, 2026 00:15
@laminne laminne added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit 1dacc61 Apr 13, 2026
5 checks passed
@laminne laminne deleted the feat/1339-config branch April 13, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: 各種設定をファイルから読み込むようにする

2 participants