Skip to content

fix: paginated by default, Mockingjay tab icon, refined tab title#29

Merged
punyamsingh merged 3 commits into
mainfrom
claude/elegant-mendel-mo7lqh
Jun 10, 2026
Merged

fix: paginated by default, Mockingjay tab icon, refined tab title#29
punyamsingh merged 3 commits into
mainfrom
claude/elegant-mendel-mo7lqh

Conversation

@punyamsingh

@punyamsingh punyamsingh commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Two small UX fixes plus a CI hygiene chore, rebased onto v1.3.0.

1. Paginated view is the default everywhere

Previously loadSettings() sniffed the device on first run (pointer: coarse / width < 768px) and defaulted phones to continuous scroll. The device sniff is removed — readingMode: "paginated" is the default on all devices, scroll stays a one-tap opt-in in Reader settings → Layout, and an explicitly saved mode is still respected.

2. Mockingjay tab icon + refined tab title

  • favicon.svg is now the brand's gold Mockingjay on the dark ember tile (generated from src/assets/mockingjay.svg with 11% safe padding and a soft ember glow) instead of the generic orb. Verified rendering at 128px and 32px.
  • Tab title is now "WeReadPDF — Read PDFs like a book" (root fallback + home route), short enough to survive tab truncation; the Hunger Games tagline remains in the og: tags for link previews.

3. chore: prettier-ignore the generated CHANGELOG.md

semantic-release rewrites CHANGELOG.md in its own style on every release, which left pnpm format:check failing on main after each release commit (surfaced while rebasing onto v1.3.0). It's now ignored like routeTree.gen.ts, along with .vercel/.nitro build output.

Verified on the rebased tree: tsc, pnpm lint (0 errors), pnpm format:check, pnpm build all clean; favicon confirmed in the Vercel static output.

https://claude.ai/code/session_01M73PtkGD7aScSgKFVw6nPP

@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
wereadpdf Ready Ready Preview, Comment Jun 10, 2026 9:41am

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Documentation for the reading mode setting was clarified to reflect that scroll is an explicit opt-in and paginated is the default on all devices. The loadSettings() function was simplified to shallow-merge user settings over defaults, removing device-dependent fallback logic. The changelog formatting was updated to use consistent bullet syntax.

Changes

Reading Mode Settings

Layer / File(s) Summary
ReadingMode documentation and defaults
src/lib/reader-store.ts
ReadingMode type documentation for "scroll" was updated to describe it as an explicit opt-in from settings rather than a touch-device default. DEFAULT_SETTINGS comment was adjusted to clarify that "paginated" is the product default on every device.
Settings loading simplification
src/lib/reader-store.ts
loadSettings() now uses a simple shallow merge of DEFAULT_SETTINGS with the parsed saved settings payload, removing the prior device-dependent defaultReadingMode() fallback when readingMode was missing or legacy.
Changelog formatting
CHANGELOG.md
The 1.2.0 release notes bullet lists under "Bug Fixes" and "Features" were reformatted from * bullets to - bullets; content and links remain the same.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The pages turn from touch to choice so clear,
No device guessing, just defaults near,
Settings merge simply, clean and bright,
And bullets dash on—what a sight! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ⚠️ Warning The PR title references 'Mockingjay tab icon' and 'refined tab title' but the raw_summary only documents CHANGELOG.md formatting updates and reader-store.ts reading mode changes—no icon or tab title changes are present. Update the title to accurately reflect the actual changes: focus on paginated reading mode default and CHANGELOG formatting, removing references to unimplemented features.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/elegant-mendel-mo7lqh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@punyamsingh punyamsingh changed the title fix: default to the paginated page-turn view on all devices fix: paginated by default, Mockingjay tab icon, refined tab title Jun 10, 2026
claude added 3 commits June 10, 2026 09:38
The reader previously sniffed the device on first run and defaulted
touch/narrow screens to continuous scroll. The Kindle-style paginated
presentation is the product's signature, so it is now the default
everywhere; continuous scroll remains an opt-in in reader settings, and
an explicitly saved mode is still respected.
- favicon.svg is now the brand's gold Mockingjay on the dark ember
  tile (built from src/assets/mockingjay.svg, 11% safe padding, soft
  ember glow) instead of the generic orb; verified legible at 32px
- Tab titles refined: 'WeReadPDF — Read PDFs like a book' on both the
  root fallback and the home route, so the name survives tab
  truncation; the Hunger Games tagline stays in the og tags for link
  previews
semantic-release rewrites CHANGELOG.md on every release in its own
style, which left format:check failing on main after each release
commit. Treat it like routeTree.gen.ts: generated, never
hand-formatted. Also ignore .vercel/.nitro build output.
@punyamsingh punyamsingh force-pushed the claude/elegant-mendel-mo7lqh branch from b680a13 to 00f404a Compare June 10, 2026 09:40
@punyamsingh punyamsingh merged commit 8df15e4 into main Jun 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants