Save a neon-vr recording - #2
Open
rennis250 wants to merge 1 commit into
Open
Conversation
…ve gaze to npy file and video to MP4; Add functionality to start a Neon recording and send vr.rec.begin/end events
JurajVincur
reviewed
Nov 13, 2025
| dest="record_gaze", | ||
| ) | ||
| parser.add_argument( | ||
| "-nr", |
Collaborator
There was a problem hiding this comment.
single letter or remove
JurajVincur
reviewed
Nov 13, 2025
| import threading | ||
|
|
||
| def gaze_saver(q, output_path): | ||
| import numpy as np |
Collaborator
There was a problem hiding this comment.
I would probably move this import bellow queue and threading imports
JurajVincur
reviewed
Nov 13, 2025
| if gaze is not None: | ||
| if is_first_gaze and args.record_gaze: | ||
| is_first_gaze = False | ||
| estimate = client_gaze.device.estimate_time_offset() |
Collaborator
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I think we simply didn't see that you already get a clock offset.
JurajVincur
reviewed
Nov 13, 2025
| ) | ||
| cv2.circle(undistorted, point, 10, (0, 0, 255), 2) | ||
|
|
||
| if container and frame: |
Collaborator
There was a problem hiding this comment.
I'm not sure if we should mix it here saving video could be completely independent via on_packet like thing
Line 192 in 2368ccf
although perhaps changed to non blocking manner too
we can't skip frames anyways
Contributor
Author
There was a problem hiding this comment.
We had originally put it in on_packet, but I think then it saves the full VR display, not the split with correction, and without gaze?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.