add Puppet v4.x compatibility - #91
Conversation
Phil-Friderici
commented
Aug 31, 2015
Phil-Friderici
commented
- deprecate type() in favor of type3x() (uses stdlib 4.6.0 therefore)
- add rspec tests for Puppet 3.8.x to 4.2.x
- fix rspec message "PENDING: Not yet implemented"
- align passenger-load.erb for Puppet v4 compatibility
- remove allow_failures section from Travis configuration
b3a7596 to
ea47096
Compare
|
I would like to see this module getting Puppet v4 compatible because it is used as submodule for other modules. At the moment it prevent other modules to be fully Puppet v4 compatibility. |
|
btw: this PR includes the change from PR #90 |
| } | ||
|
|
||
| if type($include_build_tools) == 'string' { | ||
| if type3x($include_build_tools) == 'string' { |
There was a problem hiding this comment.
Would it be better to use is_string to avoid calling a deprecated function like type3x?
For example:
if is_string($include_build_tools) {
...There was a problem hiding this comment.
I guess that type3x will be supported much longer [1] than needed. If this should be a blocker, I will happily change it to use is_string() instead. Just drop me a line.
[1] https://github.com/puppetlabs/puppetlabs-stdlib#limitations
There was a problem hiding this comment.
I don't think type3x() or is_string() are going anywhere, though puppet 4 patterns don't need either of them. And either function is just one side of the same coin.
3 participants
