fix: improve test.html accuracy and visibility for multiple rules#206
Merged
Conversation
…sible The inline-grid container was shrinking to content width, making justify-items: center visually indistinguishable. Adding explicit width makes the centering effect obvious for visual verification.
…bility - Move misplaced ok cases from "Should warn" to "Should NOT warn" section - Add missing warn cases: inline and table-cell with place-items - Add height/background to warn cases for visual confirmation - Add flex-wrap: wrap to place-content flex cases so align-content is effective - Clarify labels to explain why each case is ok (which halves are effective)
…le skill Learned from container-no-place audit that test.html cases can have misplaced sections, misleading labels, and insufficient styling to visually confirm the CSS effect.
These cases tested internal dedup logic (physical→logical mapping) which is already covered by unit tests. They add no visual verification value since display:contents has no box regardless of writing-mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
width: 200pxto inline-grid test case sojustify-items: centereffect is visually confirmableflex-wrap: wrapto flex cases soalign-contentis visually effectiveTest plan
pnpm test— 1001 tests passpnpm test:e2e— 20 tests pass