Skip to content

refactor: use type hinting from php 7.1#46

Open
Niktux wants to merge 3 commits into
masterfrom
nln-type-hinting
Open

refactor: use type hinting from php 7.1#46
Niktux wants to merge 3 commits into
masterfrom
nln-type-hinting

Conversation

@Niktux

@Niktux Niktux commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Partial
PHPUnit & Behat ok

@Niktux Niktux requested a review from lebris February 5, 2020 13:36
@codecov

codecov Bot commented Feb 5, 2020

Copy link
Copy Markdown

Codecov Report

Merging #46 into master will decrease coverage by 0.23%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
- Coverage     68.84%   68.61%   -0.24%     
- Complexity      362      369       +7     
============================================
  Files            48       48              
  Lines          1146     1147       +1     
============================================
- Hits            789      787       -2     
- Misses          357      360       +3
Impacted Files Coverage Δ Complexity Δ
src/Clients/Pecl.php 0% <0%> (ø) 19 <18> (+1) ⬆️
src/Messages/Bodies/StreamedFile.php 100% <100%> (ø) 13 <9> (ø) ⬇️
src/Clients/ChunkedMessageClient.php 100% <100%> (ø) 8 <8> (+1) ⬆️
src/Messages/Bodies/NullBody.php 100% <100%> (ø) 6 <5> (+1) ⬆️
src/Clients/InMemory.php 100% <100%> (+8.33%) 9 <7> (+1) ⬆️
src/Messages/Chunks/ChunkSize.php 100% <100%> (ø) 6 <2> (ø) ⬇️
...agementStrategies/NullMemoryManagementStrategy.php 100% <100%> (ø) 2 <2> (ø) ⬇️
src/Messages/Chunks/ChunkMetadata.php 100% <100%> (ø) 8 <8> (ø) ⬇️
src/Messages/Bodies/StreamedBinary.php 100% <100%> (ø) 4 <2> (ø) ⬇️
src/Messages/Bodies/Text.php 100% <100%> (ø) 11 <5> (ø) ⬇️
... and 7 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants