Skip to content

runtime: fix PATH - #234

Merged
ConnorNelson merged 1 commit into
mainfrom
codex/runtime-fix-path
Jun 19, 2026
Merged

runtime: fix PATH#234
ConnorNelson merged 1 commit into
mainfrom
codex/runtime-fix-path

Conversation

@ConnorNelson

Copy link
Copy Markdown
Member

Summary

  • prepend stable challenge/workspace runtime paths to the image PATH
  • derive /run/workspace/profile from the entrypoint path instead of passing PWN_WORKSPACE into containers
  • expose /run/challenge/bin when /challenge/bin exists

Tests

  • nix build .#pwn-workspace-runtime
  • pwnshop run smoke check for PATH/profile links

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75e07ab415

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +168 to +170
if err := linkChallengeBin(); err != nil {
return err
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve .init-created challenge bins

Because linkChallengeBin() runs during setupRunDirectories() before .init is executed, /run/challenge/bin is never created when a challenge creates /challenge/bin from .init instead of shipping it in the image. For challenges based on the generic challenges/common/Dockerfile.j2, which does not itself add /challenge/bin back to the image PATH, those runtime-created tools were previously found through the hard-coded /challenge/bin entry but now remain unreachable for the whole session; create the symlink unconditionally or refresh it after runInit().

Useful? React with 👍 / 👎.

@ConnorNelson
ConnorNelson merged commit a48ba75 into main Jun 19, 2026
23 checks passed
@ConnorNelson
ConnorNelson deleted the codex/runtime-fix-path branch June 19, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant