Skip to content

Format Discord feedback tests - #271

Merged
zardus merged 1 commit into
mainfrom
fix/format-discord-feedback-test
Aug 1, 2026
Merged

Format Discord feedback tests#271
zardus merged 1 commit into
mainfrom
fix/format-discord-feedback-test

Conversation

@zardus

@zardus zardus commented Aug 1, 2026

Copy link
Copy Markdown
Member

Format the Discord feedback unit test with the repository's configured Ruff formatter.

This is a mechanical one-file change needed to restore the repository-wide nix-fmt check on current main and unblock otherwise-clean PRs.

Validation:

  • nix fmt --no-write-lock-file -- tools/feedback/tests/test_discord_feedback.py
  • nix develop --command python -m unittest tools/feedback/tests/test_discord_feedback.py (36 tests)

@zardus
zardus merged commit eea3159 into main Aug 1, 2026
5 checks passed
@zardus
zardus deleted the fix/format-discord-feedback-test branch August 1, 2026 06:02
zardus added a commit that referenced this pull request Aug 1, 2026
## Summary

- recreate /run/dojo/sys/workspace/privileged for local pwnshop
workspaces
- expose the legacy standard-workspace value zero plus newline with mode
0444
- keep workspace practice mode separate from challenge privilege and
runtime selection

## Why

Production Dojo provides this file through its read-only DojoFS mount.
The local Nix workspace does not. Legacy Green /usr/local/bin/vm helpers
read it on every non-root invocation and otherwise fail with
FileNotFoundError. Restoring this ambient workspace contract centrally
avoids changing any challenge.

## Verification

- targeted formatter check: clean
- workspace-agent packages build with go test ./...
- independent mainline workspace launch as uid 1000: value zero, mode
0444
- integration-stack real solves from kernel-security,
speculative-execution, and system-exploitation: 3 challenges / 6
testcases


## CI prerequisite

The formatter-only fix in #271 is merged into main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant