feed: fix challenge_solve events showing wrong dojo - #1052
Open
adamdoupe wants to merge 1 commit into
Open
Conversation
DojoChallenge.solve() only receives the CTFd challenge_id, so it used DojoChallenges.query.filter_by(challenge_id=...).first() to find dojo context for the feed event. When the same challenge exists in multiple dojos, this returned an arbitrary match rather than the dojo the user actually solved in. Move feed publishing to DojoChallengeSolve.post(), where the correct dojo, module, and dojo_challenge are already resolved from the URL. Add regression test verifying the feed event contains the correct dojo_id and module_id after a solve. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DojoChallenges.query.filter_by(challenge_id=...).first()inDojoChallenge.solve(), which returned an arbitrary match rather than the dojo the user actually solved inDojoChallengeSolve.post()where the correct dojo, module, and dojo_challenge are already resolved from the request URLTest plan
test_feed_solve_shows_correct_dojoregression test verifying feed events contain the correct dojo_id and module_id🤖 Generated with Claude Code