Skip to content

Detach converted imported challenges - #1110

Open
zardus wants to merge 1 commit into
masterfrom
codex/issue-1037-import-conversion
Open

Detach converted imported challenges#1110
zardus wants to merge 1 commit into
masterfrom
codex/issue-1037-import-conversion

Conversation

@zardus

@zardus zardus commented Jul 24, 2026

Copy link
Copy Markdown
Member

Fixes #1037

Summary

  • exclude imported challenge associations when looking for a native challenge to reuse
  • removing import now creates a destination-owned challenge instead of mutating the source challenge

Testing

  • convert an imported challenge without deleting it first
  • verify the source is unchanged, the destination gets its own flag and identity, and repeating the update is stable

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31c9fd335d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread dojo_plugin/worker/handlers/activity.py Outdated
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@zardus
zardus force-pushed the codex/issue-1037-import-conversion branch from 7e65fc4 to a376135 Compare July 26, 2026 16:26
@zardus
zardus changed the base branch from master to codex/ci-harden-dojo-tests July 26, 2026 16:26
@zardus
zardus force-pushed the codex/issue-1037-import-conversion branch from a376135 to 6e9cf91 Compare July 26, 2026 18:06
@zardus
zardus force-pushed the codex/ci-harden-dojo-tests branch from cddd17c to c09419a Compare July 26, 2026 18:06
@zardus
zardus force-pushed the codex/issue-1037-import-conversion branch from 6e9cf91 to 7fb6578 Compare July 26, 2026 18:39
zardus added a commit that referenced this pull request Jul 26, 2026
## Summary

- make the stats-worker cold-start regression deterministic by stopping
the worker, clearing the target cache, and verifying its exact
cold-start initialization
- make database-shell errors fail tests immediately and surface
PostgreSQL diagnostics
- raise the test-step limit from 15 to 20 minutes; recent remote
#1111/#1113 test steps took up to 16m33s

## Scope

This PR is strictly CI/test-only. It changes exactly:

- `.github/workflows/ci.yml`
- `test/test_background_stats.py`
- `test/utils.py`

It contains no runtime, production, image-build, Compose, or dependency
changes.

## Validation

- Python syntax check
- workflow YAML parse
- whitespace check
- full single-node and multi-node suites in GitHub Actions

## Stack

The seven feature PRs (#1105, #1106, #1108, #1110, #1111, #1112, and
#1113) each contain one feature-only commit directly above this branch.

Shared schema-startup hardening is isolated in #1115. Image-build
patch-runner hardening is isolated in #1116. Neither is a prerequisite
for any feature PR.

Merge this PR first, then retarget the nine sibling PRs to `master`
before deleting this branch.
Base automatically changed from codex/ci-harden-dojo-tests to master July 26, 2026 22:31
@zardus
zardus force-pushed the codex/issue-1037-import-conversion branch 2 times, most recently from 614093f to eeac667 Compare July 27, 2026 02:30
@zardus zardus changed the title Make imported challenge conversion reliable Detach converted imported challenges Jul 27, 2026
@zardus
zardus force-pushed the codex/issue-1037-import-conversion branch 2 times, most recently from ce9c33c to f9e2ae6 Compare July 27, 2026 05:50
@zardus
zardus force-pushed the codex/issue-1037-import-conversion branch from f9e2ae6 to 95b3d49 Compare July 27, 2026 17:24
@zardus

zardus commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

@ConnorNelson thoughts on the way this guy is checking for imports? It's the only way that doesn't FP on previously-transferred chals without database changes. Probably okay for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Converting an imported challenge to a non-imported challenge is weird

1 participant