Key module scoreboards by module ID - #1113
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/pwncollege/dojo/blob/622a71f43c9da57ce1448de0aefa129b6e40a423/dojo#L277-L279
When a deployment has SKIP_COLD_START in the stats-worker environment, this restore path starts the existing stats-worker container with that same setting, but worker/__main__.py then skips initialization and never emits Cold start complete - all stats initialized. After pg_restore and FLUSHDB, dojo restore will wait the full timeout, report failure, and the cleanup path leaves services stopped even though the database restore already committed; the restore rebuild should force cold start or recognize a separate successful rebuild signal.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
8630b49 to
2792576
Compare
cddd17c to
c09419a
Compare
2792576 to
b6c0e53
Compare
## Summary - make the stats-worker cold-start regression deterministic by stopping the worker, clearing the target cache, and verifying its exact cold-start initialization - make database-shell errors fail tests immediately and surface PostgreSQL diagnostics - raise the test-step limit from 15 to 20 minutes; recent remote #1111/#1113 test steps took up to 16m33s ## Scope This PR is strictly CI/test-only. It changes exactly: - `.github/workflows/ci.yml` - `test/test_background_stats.py` - `test/utils.py` It contains no runtime, production, image-build, Compose, or dependency changes. ## Validation - Python syntax check - workflow YAML parse - whitespace check - full single-node and multi-node suites in GitHub Actions ## Stack The seven feature PRs (#1105, #1106, #1108, #1110, #1111, #1112, and #1113) each contain one feature-only commit directly above this branch. Shared schema-startup hardening is isolated in #1115. Image-build patch-runner hardening is isolated in #1116. Neither is a prerequisite for any feature PR. Merge this PR first, then retarget the nine sibling PRs to `master` before deleting this branch.
f316d47 to
7638e99
Compare
zardus
changed the title
7638e99 to
1e40661
Compare
zardus
changed the title
|
@adamdoupe do you see any issues with this? It sets module ID instead of index for the cache key, to avoid the issue where inserting a module midway through a dojo makes things really weird. Other than having to regenerate caches on start, it should be good, right? |
1 participant
Fixes #1097
Summary
iddiscriminator so numeric module IDs cannot collide with legacy index keysTesting