You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry for delay,
I added support for authentication. Right now it works with mongodb version 2.6 (authentication method is MONGODB-CR). I have plans to modify it for newer version of mongodb but I think that there will be problem with hpfeeds feedbroker. It uses custom mongo client (evnet.mongodb) and it does not support newer auth methods. But right now it should work and you can test it.
And then replace all those Clio(...) object creations with mhn.new_clio_conection(). This will make this much easier to maintain if we have to make changes with this again.
Why make the MHN hpfeeds mongo config different for MHN vs mnemosyne? It seems like there should just be one mongo instance for these. When the install gets more complicated people make mistakes and their installs fail. Any ideas on how we could make this simpler?
I am working on these changes but I still need to test them. I will let you know when I will finish.
Regarding second point, what about to create another install script that will be called first. In this script could be asked for all configuration questions and answers could be stored in some tmp file. Other install scripts will look for this file and if it exists, script will use values from it. Otherwise script will ask for configuration as usual. What do you think of this solution?
This might be more complicated then you're willing to contribute, but ... My preference would be to only set the ENV variables in one place and have them take effect on all processes that used them anytime someone changed the variables in that one file and restarted the processes.
create a file in /opt/mhn/ called environmentrc that would contain some ENV vars that represent the mongo options (and later we could add other MHN related ENVs as needed).
modify anything that uses mongo to check the ENV variables named in this file (os.getenv('MONGO_HOST')).
modify the supervisor scripts that manages these processes so it loads the /opt/mhn/enironmentrc file for any processes that use mongo to load the variables from this file.
I made some tests and it looks like there is no problem and it works.
Regarding changes you suggesting, I can look at it later, but right now I don't have the time. Sorry. But I briefly checked if it would be feasible and I found one problem. Supervisor can't read environment variables from file. So one solution would be put ENV vars directly in supervisor script, but only on one place in supervisord section. Other scripts then inherit those variables (Supervisor/supervisor#771).
@standa4 do you know if this still works with the latest code? If so I will gladly merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes require improved versions of hpfeeds and mnemosyne (pull-requests were created).