Replace broken Unsplash image URLs with Picsum in light-dark guide#2341
Open
tmchow wants to merge 1 commit intopydata:mainfrom
Open
Replace broken Unsplash image URLs with Picsum in light-dark guide#2341tmchow wants to merge 1 commit intopydata:mainfrom
tmchow wants to merge 1 commit intopydata:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The light and dark themes documentation page uses
source.unsplash.comURLs for example images, but this service no longer serves images, leaving all examples on the page broken.This replaces the Unsplash URLs with
picsum.photosURLs (consistent with the approach used in #2190 for other docs pages) and removes the now-unnecessaryunsplash.comentry fromlinkcheck_ignoreinconf.py.Fixes #2208
Changes
docs/user_guide/light-dark.rst: Replace allsource.unsplash.comimage URLs withpicsum.photosequivalents (id/237 for the dark-theme cat image, id/1025 for the light-theme dog image)docs/conf.py: Remove"https://unsplash.com/"fromlinkcheck_ignoresince no Unsplash URLs remain in the docs