broken nightly wheels ci and permissions for the nightly tests#11282
Merged
keewis merged 8 commits intopydata:mainfrom Apr 8, 2026
Merged
broken nightly wheels ci and permissions for the nightly tests#11282keewis merged 8 commits intopydata:mainfrom
keewis merged 8 commits intopydata:mainfrom
Conversation
github-actions
bot
added
the
Automation
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Did a full review of the code. One comment, but otherwise looks good
Co-authored-by: Nick Hodgskin <36369090+VeckoTheGecko@users.noreply.github.com>
Collaborator
Author
|
I'll continue monitoring CI to see what breaks |
maxrjones
pushed a commit
to maxrjones/xarray
that referenced
this pull request
Apr 8, 2026
…a#11282) * remove the accidentally copied pypi publish step * separate test execution from issue creation * upload the artifact only if the tests failed * correct source of the log-file path * debug: print github output [skip-rtd] * typo [skip-rtd] * correct the path to the log file Co-authored-by: Nick Hodgskin <36369090+VeckoTheGecko@users.noreply.github.com> --------- Co-authored-by: Nick Hodgskin <36369090+VeckoTheGecko@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zizmorto lint github action workflows #11269Looks like I forgot to remove the "upload to pypi" step when copying the job over to the nightly wheels ci.
This also splits out the creation of the upstream-dev issue into a separate job, allowing us to fully isolate the nightly tests into a read-only job. As an additional bonus, this simplifies debugging the
scientific-python/issue-from-pytest-log-actionshould it ever fail, as the log is available as an artifact.cc @VeckoTheGecko