Fix test_batch_norm to check module attributes instead of relying on string representation#10657
Merged
puririshi98 merged 7 commits intopyg-team:masterfrom Apr 8, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10657 +/- ##
==========================================
- Coverage 86.11% 84.18% -1.93%
==========================================
Files 496 510 +14
Lines 33655 36022 +2367
==========================================
+ Hits 28981 30325 +1344
- Misses 4674 5697 +1023 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akihironitta
reviewed
Apr 6, 2026
akihironitta
reviewed
Apr 6, 2026
akihironitta
reviewed
Apr 6, 2026
akihironitta
approved these changes
Apr 6, 2026
Co-authored-by: Akihiro Nitta <akihiro@kumo.ai>
Co-authored-by: Akihiro Nitta <akihiro@kumo.ai>
auto-merge was automatically disabled
April 7, 2026 16:20
Invalid email address
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_batch_normwas recently changed in PR#10647 (Fix CI failing with PyTorch 2.12+), but it still fails with some PyTorh 2.12 versions, andtorch-2.12.0a0+0291f960b6.nvinternal.main.46693258is one of them.Current PR:
WITH_PT212flag.BatchNormand nativetorch.nn.BatchNorm1d.The fix was tested with :